Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ecall demo with Keccak-f #717

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Ecall demo with Keccak-f #717

wants to merge 20 commits into from
+326 −15

Conversation

naure
Copy link
Collaborator

@naure naure commented Dec 9, 2024 •
edited
Loading

  • Expand StepRecord to support multiple accesses to registers and memory (beyond standard instructions).
  • Introduce a module for syscall witness generation. See fn handle_syscall(…)
  • Witness generation for Keccak-f. Same format as sp1.
  • Runtime wrapper function syscall_keccak_permute.
  • Test program using Keccak-f and concrete values.

This was linked to issues Dec 10, 2024
Precompile Architecture #693
Open
Precompile Trace Generation. #728
Open
@naure naure requested a review from lispc December 10, 2024 11:23
@naure naure mentioned this pull request Dec 11, 2024
Open
matthiasgoergens
matthiasgoergens reviewed Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@matthiasgoergens matthiasgoergens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, please see comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasgoergens matthiasgoergens matthiasgoergens left review comments

@kunxian-xia kunxian-xia Awaiting requested review from kunxian-xia

@mcalancea mcalancea Awaiting requested review from mcalancea

@lispc lispc Awaiting requested review from lispc

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Precompile Trace Generation. Precompile Architecture
2 participants
@naure @matthiasgoergens